fix: Provide SpawnWithObservers property alternative to CheckObjectVisibility [MTT-6353]#2568
Merged
NoelStephensUnity merged 3 commits intodevelopfrom May 23, 2023
Conversation
3 tasks
ShadauxCat
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides users with an alternate way to handle spawning NetworkObjects with no observers via the
NetworkObject.SpawnWithObserversproperty (default is true). This will help to avoid issue #2546 where using a CheckObjectVisibility handler that always returns false (i.e. never is changed) would result in NetworkShow not being able to function correctly.MTT-6353
Changelog
NetworkObject.SpawnWithObserversproperty (default is true) that when set to false will spawn aNetworkObjectwith no observers and will not be spawned on any client untilNetworkObject.NetworkShowis invoked.Testing and Documentation
NetworkObjectOnSpawnTests.ObserverSpawnTests.